Code-Inc/intelligence-terminal
2
0
Fork 0
Code Issues 11 Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request 'fix: fall back from invalid DAVE presence timezone' (#74) from codex/issue-73-presence-timezone-fallback into codex/production-intelligence-terminal
All checks were successful
Codex Template Compliance / template-compliance (push) Successful in 6s
Details
Release Dry Run / release-dry-run (push) Successful in 16s
Details
Build / test-and-image (push) Successful in 28s
Details

Browse Source
This commit was merged in pull request #74.
This commit is contained in:
MrSphay
2026-07-05 21:03:33 +00:00
parent 20243d159f 09ee1d9006
commit f0a8162202
2 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/agent/dave-presence.mjs
View File

@@ -78,8 +78,12 @@ export class DavePresence {
const profile = this.profileStore?.getAgentProfile(); const profile = this.profileStore?.getAgentProfile();
if (!profile) return this._result(false, 'profile_missing'); if (!profile) return this._result(false, 'profile_missing');
const timezone = profile.timezone || this.fallbackTimezone; let timezone = profile.timezone || this.fallbackTimezone;
const clock = localClock(now, timezone); let clock = localClock(now, timezone);
if (!clock && timezone !== this.fallbackTimezone) {
timezone = this.fallbackTimezone;
clock = localClock(now, timezone);
}
if (!clock) return this._result(false, 'invalid_timezone'); if (!clock) return this._result(false, 'invalid_timezone');
this._rollDay(clock.day); this._rollDay(clock.day);
if (this.state.sentCount >= this.maxPerDay) return this._result(false, 'daily_limit'); if (this.state.sentCount >= this.maxPerDay) return this._result(false, 'daily_limit');

8
test/dave-presence.test.mjs
View File

@@ -89,3 +89,11 @@ test('local clock uses the profile timezone', () => {
assert.deepEqual(localClock(new Date('2026-07-06T12:30:00Z'), 'Europe/Berlin'), { day: '2026-07-06', time: '14:30' }); assert.deepEqual(localClock(new Date('2026-07-06T12:30:00Z'), 'Europe/Berlin'), { day: '2026-07-06', time: '14:30' });
assert.equal(localClock(new Date(), 'Invalid/Timezone'), null); assert.equal(localClock(new Date(), 'Invalid/Timezone'), null);
}); });
test('invalid profile timezone falls back to configured operational timezone', async () => {
const { presence, messages, calls } = setup({ profile: { timezone: 'not-a-timezone' } });
const outcome = await presence.tick(new Date('2026-07-06T12:00:00Z'));
assert.equal(outcome.reason, 'sent');
assert.equal(messages.length, 1);
assert.match(calls[0].prompt, /timezone: UTC/);
});