fix: add download attribute to fix JAR files saving as ZIP in Chromium (#6065)

* fix: add download attribute to fix JAR files saving as ZIP in Chromium

- JAR files were downloading with a `.zip` extension in Chromium-based browsers (Chrome, Edge, Arc, Brave, Opera, Vivaldi)
- Root cause: JAR files are ZIP archives internally, so Chromium sniffs the `Content-Type` as `application/zip` and overrides the filename extension when no `download` attribute is present
- Fix: add `download="<filename>"` to all file download `<a>` tags so the browser uses the original filename from the API

* fix: add download attribute to remaining download links

Missed in initial pass: changelog page button, versions overflow
menu, settings/versions overflow menu. Also adds `download` prop
to Button and OverflowMenu to support dropdown link items.

Adds missing `getPrimaryFile` definition in changelog.vue.

---------

Co-authored-by: Mr_chank <180248271+chank-op@users.noreply.github.com>
Co-authored-by: Prospector <6166773+Prospector@users.noreply.github.com>

apps/frontend/src/pages/[type]/[id]/changelog.vue

@@ -57,6 +57,7 @@
 									<a
 										class="ml-auto"
 										:href="createDownloadUrl(version)"
+										:download="getPrimaryFile(version).filename"
 										:title="`Download ${version.name}`"
 									>
 										<DownloadIcon aria-hidden="true" />

apps/frontend/src/pages/[type]/[id]/settings/versions.vue

@@ -111,6 +111,7 @@
 								color: 'primary',
 								hoverFilled: true,
 								link: createDownloadUrl(version),
+								download: getPrimaryFile(version).filename,
 								action: () => {
 									emit('onDownload')
 								},

apps/frontend/src/pages/[type]/[id]/version/[version].vue

@@ -140,6 +140,7 @@
 					<a
 						v-tooltip="primaryFile.filename + ' (' + formatBytes(primaryFile.size) + ')'"
 						:href="decoratedPrimaryFileUrl"
+						:download="primaryFile.filename"
 						@click="emit('onDownload')"
 					>
 						<DownloadIcon aria-hidden="true" />
@@ -307,6 +308,7 @@
 						:href="decorateDownloadUrl(file.url)"
 						class="raised-button"
 						:title="`Download ${file.filename}`"
+						:download="file.filename"
 						tabindex="0"
 					>
 						<DownloadIcon aria-hidden="true" />

apps/frontend/src/pages/[type]/[id]/versions.vue

@@ -47,6 +47,7 @@
 						<a
 							v-tooltip="`Download`"
 							:href="createDownloadUrl(version)"
+							:download="getPrimaryFile(version).filename"
 							class="hover:!bg-button-bg [&>svg]:!text-green"
 							aria-label="Download"
 							@click="emit('onDownload')"
@@ -101,6 +102,7 @@
 									color: 'primary',
 									hoverFilled: true,
 									link: createDownloadUrl(version),
+									download: getPrimaryFile(version).filename,
 									action: () => {
 										emit('onDownload')
 									},

packages/ui/src/components/base/Button.vue

@@ -11,6 +11,10 @@ const props = defineProps({
 		type: Boolean,
 		default: false,
 	},
+	download: {
+		type: String,
+		default: null,
+	},
 	action: {
 		type: Function,
 		default: null,
@@ -106,6 +110,7 @@ const classes = computed(() => {
 		class="btn"
 		:class="classes"
 		:href="disabled ? undefined : link"
+		:download="download || undefined"
 		:target="external ? '_blank' : '_self'"
 		@click="
 			(event) => {

packages/ui/src/components/base/OverflowMenu.vue

@@ -36,6 +36,7 @@
 							: undefined
 					"
 					:link="option.link ? option.link : undefined"
+					:download="option.download ? option.download : undefined"
 					:external="option.external ? option.external : false"
 					:disabled="option.disabled"
 					@click="
@@ -76,6 +77,7 @@ interface Item extends BaseOption {
 	icon?: Component
 	action?: (event?: MouseEvent) => void
 	link?: string
+	download?: string
 	external?: boolean
 	color?:
 		| 'primary'

packages/ui/src/components/version/VersionSummary.vue

@@ -12,7 +12,12 @@
 			</p>
 		</div>
 		<ButtonStyled color="brand">
-			<a :href="downloadUrl" class="min-w-0" @click="emit('onDownload')">
+			<a
+				:href="downloadUrl"
+				:download="primaryFilename"
+				class="min-w-0"
+				@click="emit('onDownload')"
+			>
 				<DownloadIcon aria-hidden="true" /> Download
 			</a>
 		</ButtonStyled>
@@ -42,12 +47,17 @@ const props = defineProps<{
 	decorateDownloadUrl?: (url: string) => string
 }>()
 
+const primaryFile = computed<VersionFile>(
+	() => props.version.files.find((x) => x.primary) || props.version.files[0],
+)
+
 const downloadUrl = computed(() => {
-	const primary: VersionFile = props.version.files.find((x) => x.primary) || props.version.files[0]
+	const raw = primaryFile.value.url
-	const raw = primary.url
 	return props.decorateDownloadUrl ? props.decorateDownloadUrl(raw) : raw
 })
 
+const primaryFilename = computed(() => primaryFile.value.filename)
+
 const emit = defineEmits<{
 	onDownload: []
 	onNavigate: [url: string]