Align Windows signing with MrTrust contract
This commit is contained in:
@@ -8,7 +8,7 @@ Release artifacts are not published yet.
|
||||
|
||||
- Connected Library can track public Git-hosted modpack manifests.
|
||||
- Per-pack auto-update can be enabled after a pack is connected.
|
||||
- Windows release artifacts are signed with the MrTrust code-signing certificate.
|
||||
- Windows release artifacts are signed with the MrTrust code-signing certificate using `osslsigncode` on the Ubuntu Gitea runner.
|
||||
- Gitea Actions are used as the verification runner.
|
||||
|
||||
## Security
|
||||
@@ -16,7 +16,7 @@ Release artifacts are not published yet.
|
||||
- Dependency audit: pending runner/toolchain confirmation.
|
||||
- Secret handling: no tokens are stored by Connected Library v1.
|
||||
- External network calls: public HTTPS manifest and `.mrpack` downloads.
|
||||
- Windows trust: MrTrust-installed users can trust Modrinth Plus only when artifacts are signed with the matching MrSphay certificate chain.
|
||||
- Windows trust: MrTrust-installed users can trust Modrinth Plus only when artifacts are signed with the matching MrSphay certificate chain. MrTrust is distributed separately at `https://git.wilkensxl.de/MrSphay/MrTrust/releases`.
|
||||
|
||||
## Verification
|
||||
|
||||
@@ -25,7 +25,7 @@ Release artifacts are not published yet.
|
||||
| Gitea Actions build | Must pass before release |
|
||||
| Frontend lint | Covered by Gitea build workflow |
|
||||
| Rust clippy | Covered by Gitea build workflow |
|
||||
| MrTrust signing | Required by Gitea build workflow |
|
||||
| MrTrust signing | Required by Gitea build workflow with `MRTRUST_CODESIGN_PFX_BASE64` and `MRTRUST_CODESIGN_PFX_PASSWORD` |
|
||||
| Artifact download | Pending release packaging |
|
||||
|
||||
## Notes
|
||||
|
||||
@@ -4,13 +4,15 @@ Modrinth Plus uses the existing Tauri updater flow from the upstream Modrinth Ap
|
||||
|
||||
The updater requires signing. Tauri does not allow unsigned updater installs, so the Gitea repository must provide these Actions secrets:
|
||||
|
||||
- `MRTRUST_CODE_SIGNING_PFX_BASE64`: base64-encoded `MrSphay-CodeSigning.pfx` from MrTrust.
|
||||
- `MRTRUST_PFX_PASSWORD`: password for the MrTrust code-signing PFX.
|
||||
- `MRTRUST_CODESIGN_PFX_BASE64`: base64-encoded `MrSphay-CodeSigning.pfx` from MrTrust.
|
||||
- `MRTRUST_CODESIGN_PFX_PASSWORD`: password for the MrTrust code-signing PFX.
|
||||
- `TAURI_SIGNING_PRIVATE_KEY`: private key generated by `tauri signer generate`.
|
||||
- `TAURI_SIGNING_PRIVATE_KEY_PASSWORD`: optional key password.
|
||||
- `TAURI_SIGNING_PUBLIC_KEY`: public key generated next to the private key.
|
||||
- `REGISTRY_TOKEN`: Gitea token with package write access.
|
||||
|
||||
MrTrust signing and Tauri updater signing are separate. If only the two `MRTRUST_*` secrets are set, the workflow still builds and publishes a MrTrust-signed Windows installer, but it does not publish `latest.json` for in-app reload updates.
|
||||
|
||||
Generate a keypair with the Tauri CLI:
|
||||
|
||||
```powershell
|
||||
@@ -19,7 +21,7 @@ pnpm --filter @modrinth/app exec tauri signer generate -- -w "$env:USERPROFILE\.
|
||||
|
||||
Use the `.key` file content as `TAURI_SIGNING_PRIVATE_KEY` and the `.key.pub` file content as `TAURI_SIGNING_PUBLIC_KEY`.
|
||||
|
||||
Encode the MrTrust PFX for the `MRTRUST_CODE_SIGNING_PFX_BASE64` secret:
|
||||
Encode the MrTrust PFX for the `MRTRUST_CODESIGN_PFX_BASE64` secret:
|
||||
|
||||
```powershell
|
||||
[Convert]::ToBase64String([IO.File]::ReadAllBytes(".\private\MrSphay-CodeSigning.pfx"))
|
||||
@@ -32,3 +34,11 @@ https://git.wilkensxl.de/api/packages/MrSphay/generic/modrinth-plus/latest/lates
|
||||
```
|
||||
|
||||
The Windows installer and bundled executables are Authenticode-signed with the MrTrust code-signing certificate. Users who installed MrTrust before installing Modrinth Plus should see the artifacts as signed by the trusted MrSphay certificate chain. MrTrust does not disable Defender, SmartScreen, UAC, or enterprise policy.
|
||||
|
||||
MrTrust itself is intentionally separate from Modrinth Plus. Download the current `MrTrust-<version>.zip` from:
|
||||
|
||||
```text
|
||||
https://git.wilkensxl.de/MrSphay/MrTrust/releases
|
||||
```
|
||||
|
||||
Run `MrTrust.exe` once to install trust for MrSphay-signed apps. Open it again and choose `Remove trust` to reverse that trust.
|
||||
|
||||
Reference in New Issue
Block a user