From 83ea7f684be1921ca2870ab04e2cd640d40e64c3 Mon Sep 17 00:00:00 2001
From: Truman Gao <106889354+tdgao@users.noreply.github.com>
Date: Wed, 11 Mar 2026 11:45:06 -0700
Subject: [PATCH] fix: permissions for server compatibility (#5525)

* disable buttons for server compatibility settings

* update permissions checkboxes
---
 .../ui/project-settings/CompatibilityCard.vue | 23 +++++++++++++++----
 .../pages/[type]/[id]/settings/members.vue    |  9 ++++++--
 2 files changed, 25 insertions(+), 7 deletions(-)

diff --git a/apps/frontend/src/components/ui/project-settings/CompatibilityCard.vue b/apps/frontend/src/components/ui/project-settings/CompatibilityCard.vue
index d7c18e666..e5270fb04 100644
--- a/apps/frontend/src/components/ui/project-settings/CompatibilityCard.vue
+++ b/apps/frontend/src/components/ui/project-settings/CompatibilityCard.vue
@@ -40,13 +40,17 @@
 					</div>
 				</div>
 				<ButtonStyled v-if="content" type="outlined">
-					<button class="!border-[1px]" @click="handleSwitchCompatibility">
+					<button
+						class="!border-[1px]"
+						@click="handleSwitchCompatibility"
+						:disabled="!hasPermission"
+					>
 						<ArrowLeftRightIcon />
 						Switch type
 					</button>
 				</ButtonStyled>
 				<ButtonStyled v-else>
-					<button @click="handleSetCompatibility">
+					<button @click="handleSetCompatibility" :disabled="!hasPermission">
 						<ComponentIcon />
 						Set compatibility
 					</button>
@@ -183,14 +187,18 @@
 				</div>
 
 				<ButtonStyled v-if="content">
-					<button class="!w-full !max-w-[160px]" @click="handleUpdateContent">
+					<button
+						class="!w-full !max-w-[160px]"
+						@click="handleUpdateContent"
+						:disabled="!hasPermission"
+					>
 						<RefreshCwIcon />
 						Update
 					</button>
 				</ButtonStyled>
 			</div>
 		</div>
-		<ServerCompatibilityModal ref="serverCompatibilityModal" />
+		<ServerCompatibilityModal v-if="hasPermission" ref="serverCompatibilityModal" />
 	</div>
 </template>
 
@@ -224,10 +232,15 @@ const serverCompatibilityModal = useTemplateRef<InstanceType<typeof ServerCompat
 	'serverCompatibilityModal',
 )
 
-const { projectV3 } = injectProjectPageContext()
+const { projectV3, currentMember } = injectProjectPageContext()
 const { labrinth } = injectModrinthClient()
 const tags = useGeneratedState()
 
+const hasPermission = computed(() => {
+	const EDIT_DETAILS = 1 << 2
+	return ((currentMember.value?.permissions ?? 0) & EDIT_DETAILS) === EDIT_DETAILS
+})
+
 const content = computed(() => {
 	if (!projectV3.value) return null
 
diff --git a/apps/frontend/src/pages/[type]/[id]/settings/members.vue b/apps/frontend/src/pages/[type]/[id]/settings/members.vue
index a80d7cb67..557009b91 100644
--- a/apps/frontend/src/pages/[type]/[id]/settings/members.vue
+++ b/apps/frontend/src/pages/[type]/[id]/settings/members.vue
@@ -129,10 +129,11 @@
 								(currentMember?.permissions & EDIT_MEMBER) !== EDIT_MEMBER ||
 								(currentMember?.permissions & UPLOAD_VERSION) !== UPLOAD_VERSION
 							"
-							label="Upload version"
+							:label="isServerProject ? 'Update content' : 'Upload version'"
 							@update:model-value="allTeamMembers[index].permissions ^= UPLOAD_VERSION"
 						/>
 						<Checkbox
+							v-if="!isServerProject"
 							:model-value="(member?.permissions & DELETE_VERSION) === DELETE_VERSION"
 							:disabled="
 								(currentMember?.permissions & EDIT_MEMBER) !== EDIT_MEMBER ||
@@ -401,10 +402,11 @@
 								(currentMember?.permissions & UPLOAD_VERSION) !== UPLOAD_VERSION ||
 								!allOrgMembers[index].override
 							"
-							label="Upload version"
+							:label="isServerProject ? 'Update content' : 'Upload version'"
 							@update:model-value="allOrgMembers[index].permissions ^= UPLOAD_VERSION"
 						/>
 						<Checkbox
+							v-if="!isServerProject"
 							:model-value="(member?.permissions & DELETE_VERSION) === DELETE_VERSION"
 							:disabled="
 								(currentMember?.permissions & EDIT_MEMBER) !== EDIT_MEMBER ||
@@ -557,12 +559,15 @@ import { removeSelfFromTeam } from '~/helpers/teams.js'
 const { addNotification } = injectNotificationManager()
 const {
 	projectV2: project,
+	projectV3,
 	organization,
 	allMembers,
 	currentMember,
 	invalidate,
 } = injectProjectPageContext()
 
+const isServerProject = computed(() => projectV3.value?.minecraft_server != null)
+
 const cosmetics = useCosmetics()
 const auth = await useAuth()