fix: 404 when returning to collections dashboard (#5963)

* fix 404 when returning to collections dashboard, fix a couple hydration
issues

* fix clippy

* fmt

* fix hydration issue on revenue page

* fix transfer history page error

---------

Co-authored-by: aecsocket <aecsocket@tutanota.com>

packages/app-lib/src/api/pack/install_mrpack.rs

@@ -228,8 +228,7 @@ pub async fn install_zipped_mrpack_files(
 
     let num_files = pack.files.len();
     loading_try_for_each_concurrent(
-        futures::stream::iter(pack.files.into_iter())
-            .map(Ok::<PackFile, crate::Error>),
+        futures::stream::iter(pack.files).map(Ok::<PackFile, crate::Error>),
         None,
         Some(&loading_bar),
         70.0,

packages/app-lib/src/api/server_address.rs

@@ -150,8 +150,8 @@ pub async fn resolve_server_address(
         match resolver.srv_lookup(format!("_minecraft._tcp.{host}")).await {
             Err(e)
                 if e.proto()
-                    .filter(|x| x.kind().is_no_records_found())
-                    .is_some() =>
+                    .as_ref()
+                    .is_some_and(|x| x.kind().is_no_records_found()) =>
             {
                 None
             }

packages/app-lib/src/api/worlds.rs

@@ -791,7 +791,7 @@ pub async fn remove_server_from_profile(
     index: usize,
 ) -> Result<()> {
     let mut servers = servers_data::read(profile_path).await?;
-    if servers.get(index).filter(|x| !x.hidden).is_none() {
+    if servers.get(index).as_ref().is_none_or(|x| x.hidden) {
         return Err(ErrorKind::InputError(format!(
             "No removable server at index {index}"
         ))