MrSphay/Modrinth-plus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix #5243: detect file data on multi-part uploads (#5331)

Browse Source 
* fix modrinth/code#5243: detect file data on multi-part uploads

* fix return early not making handlingNewFiles = false

---------

Co-authored-by: Calum H. <calum@modrinth.com>
This commit is contained in:
Xander
2026-02-09 12:55:39 +00:00
committed by GitHub
parent 1101e71fdd
commit d9d7750781
1 changed files with 18 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
apps/frontend/src/providers/version/manage-version-modal.ts
View File

@@ -267,15 +267,20 @@ export function createManageVersionContext(
if (primaryFileIndex) swapPrimaryFile(primaryFileIndex) if (primaryFileIndex) swapPrimaryFile(primaryFileIndex)
} }
if ( if (!editingVersion.value && modal.value?.currentStageIndex === 0) {
filesToAdd.value.length === 1 && if (primaryFileIndex !== null) {
!editingVersion.value && const primaryFileData = filesToAdd.value[0]?.file
modal.value?.currentStageIndex === 0 if (primaryFileData) {
) { if (await rejectOnRedundantWrappedZip(primaryFileData)) {
if (await rejectOnRedundantWrappedZip(filesToAdd.value[0].file)) return handlingNewFiles.value = false
return
await addDetectedData() }
modal.value?.nextStage() await addDetectedData(primaryFileData)
}
if (filesToAdd.value.length === 1 && primaryFileData) {
modal.value?.nextStage()
}
}
} }
handlingNewFiles.value = false handlingNewFiles.value = false
@@ -286,7 +291,7 @@ export function createManageVersionContext(
filesToAdd.value[0] = { file } filesToAdd.value[0] = { file }
} }
if (await rejectOnRedundantWrappedZip(file)) return if (await rejectOnRedundantWrappedZip(file)) return
await addDetectedData() await addDetectedData(file)
} }
async function swapPrimaryFile(index: number) { async function swapPrimaryFile(index: number) {
@@ -297,7 +302,7 @@ export function createManageVersionContext(
;[files[0], files[index]] = [files[index], files[0]] ;[files[0], files[index]] = [files[index], files[0]]
if (await rejectOnRedundantWrappedZip(files[0].file)) return if (await rejectOnRedundantWrappedZip(files[0].file)) return
await addDetectedData() await addDetectedData(files[0].file)
} }
const tags = useGeneratedState() const tags = useGeneratedState()
@@ -490,10 +495,10 @@ export function createManageVersionContext(
return 0 return 0
} }
const addDetectedData = async () => { const addDetectedData = async (file?: File) => {
if (editingVersion.value) return if (editingVersion.value) return
const primaryFileData = filesToAdd.value[0]?.file const primaryFileData = file ?? filesToAdd.value[0]?.file
if (!primaryFileData) return if (!primaryFileData) return
try { try {