MrSphay/intelligence-terminal
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases Wiki Activity

Reddit source must stop unauthenticated .json scraping #1

New Issue
Closed
opened 2026-05-17 11:21:47 +00:00 by MrSphay · 2 comments
MrSphay commented 2026-05-17 11:21:47 +00:00
Owner
Copy Link

Synced from upstream Crucix #108: https://github.com/calesthio/Crucix/issues/108

Current status in this fork: apis/sources/reddit.mjs still falls back to https://www.reddit.com/r/.../hot.json when no OAuth token is available. That path is not acceptable for production reliability or ToS compliance.

Acceptance criteria:

  • Remove unauthenticated reddit.com hot.json scraping from runtime sweeps.
  • If REDDIT_CLIENT_ID/REDDIT_CLIENT_SECRET are missing, mark Reddit as disabled/degraded with a clear operator message.
  • If OAuth fails, classify the source error without stale data pretending to be fresh.
  • Add tests for no-credentials, OAuth-failure, and OAuth-success payload handling.
  • Update README/.env.example/source docs for Reddit credentials.
Synced from upstream Crucix #108: https://github.com/calesthio/Crucix/issues/108 Current status in this fork: apis/sources/reddit.mjs still falls back to https://www.reddit.com/r/.../hot.json when no OAuth token is available. That path is not acceptable for production reliability or ToS compliance. Acceptance criteria: - Remove unauthenticated reddit.com hot.json scraping from runtime sweeps. - If REDDIT_CLIENT_ID/REDDIT_CLIENT_SECRET are missing, mark Reddit as disabled/degraded with a clear operator message. - If OAuth fails, classify the source error without stale data pretending to be fresh. - Add tests for no-credentials, OAuth-failure, and OAuth-success payload handling. - Update README/.env.example/source docs for Reddit credentials.
MrSphay commented 2026-05-17 11:43:31 +00:00
Author
Owner
Copy Link

In Bearbeitung durch Codex auf Branch codex/issue-1-reddit-oauth. Scope: Reddit-Source entfernt unauthenticated .json fallback, klare Degradation bei fehlenden/fehlerhaften OAuth-Credentials, Tests und Doku. Ich halte die �nderungen bewusst auf Reddit/Docs/Tests begrenzt, damit parallele Arbeiten an anderen Issues sauber mergbar bleiben.

In Bearbeitung durch Codex auf Branch codex/issue-1-reddit-oauth. Scope: Reddit-Source entfernt unauthenticated .json fallback, klare Degradation bei fehlenden/fehlerhaften OAuth-Credentials, Tests und Doku. Ich halte die �nderungen bewusst auf Reddit/Docs/Tests begrenzt, damit parallele Arbeiten an anderen Issues sauber mergbar bleiben.
MrSphay commented 2026-05-17 11:48:12 +00:00
Author
Owner
Copy Link

Implementierung gepusht und PR ge�ffnet: #9

Branch: codex/issue-1-reddit-oauth
Commit: 2dee4e26132afe3eaf1242b40611041fcdcb7ab
Status: Tests lokal gr�n, wartet jetzt auf Gitea Actions/Review. Issue bitte erst beim Merge schlie�en.

Implementierung gepusht und PR ge�ffnet: https://git.wilkensxl.de/MrSphay/intelligence-terminal/pulls/9 Branch: codex/issue-1-reddit-oauth Commit: 2dee4e26132afe3eaf1242b40611041fcdcb7ab Status: Tests lokal gr�n, wartet jetzt auf Gitea Actions/Review. Issue bitte erst beim Merge schlie�en.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
design-revert
Reverts visual/design changes
 enhancement
New feature or product improvement
 frontend-redesign
Frontend redesign and app-shell/UI work
 marketing-finalization
Product presentation, README, packaging metadata, and customer-facing communication.
 product
User-facing product capability or workflow
 research
Research-originated product idea ready for implementation design
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
MrSphay
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MrSphay/intelligence-terminal#1
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?