MrSphay/intelligence-terminal
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases Wiki Activity

Improve ACLED auth diagnostics and tests #14

Merged
MrSphay merged 3 commits from codex/issue-3-acled-diagnostics-auth-tests into codex/production-intelligence-terminal 2026-05-17 15:48:06 +00:00
Conversation 0 Commits 3 Files Changed 4 +230 -122
MrSphay commented 2026-05-17 12:06:00 +00:00
Owner
Copy Link

Refs #3. This intentionally does not claim exclusive closure because a remote branch codex/issue-3-acled-diagnostics already exists from another worker.

Changes:

  • classify ACLED failures as no_credentials, auth_failed, access_denied, or api_failed
  • support ACLED_USER / ACLED_USERNAME as aliases for ACLED_EMAIL
  • make ACLED auth/data flow injectable for mocked regression tests
  • stop debug output from printing bearer token/cookie details
  • update ACLED source docs and README credential notes

Verification:

  • node --check apis/sources/acled.mjs
  • node --test test/acled-source.test.mjs
  • npm run test:unit
  • node apis/sources/acled.mjs without credentials
  • git diff --check

Merge note: I avoided package.json changes to reduce conflicts with PR #9. The ACLED test is direct-run until the test manifest is consolidated.

Refs #3. This intentionally does not claim exclusive closure because a remote branch codex/issue-3-acled-diagnostics already exists from another worker. Changes: - classify ACLED failures as no_credentials, auth_failed, access_denied, or api_failed - support ACLED_USER / ACLED_USERNAME as aliases for ACLED_EMAIL - make ACLED auth/data flow injectable for mocked regression tests - stop debug output from printing bearer token/cookie details - update ACLED source docs and README credential notes Verification: - node --check apis/sources/acled.mjs - node --test test/acled-source.test.mjs - npm run test:unit - node apis/sources/acled.mjs without credentials - git diff --check Merge note: I avoided package.json changes to reduce conflicts with PR #9. The ACLED test is direct-run until the test manifest is consolidated.
MrSphay added 1 commit 2026-05-17 12:06:01 +00:00
fix: improve acled auth diagnostics
All checks were successful
Codex Template Compliance / template-compliance (pull_request) Successful in 5s
Details
Build / test-and-image (pull_request) Successful in 49s
Details
bb139799d7
MrSphay added 1 commit 2026-05-17 14:45:26 +00:00
Merge branch 'codex/production-intelligence-terminal' into codex/issue-3-acled-diagnostics-auth-tests
All checks were successful
Codex Template Compliance / template-compliance (pull_request) Successful in 5s
Details
Build / test-and-image (pull_request) Successful in 50s
Details
43a5b642e4
MrSphay added 1 commit 2026-05-17 15:46:17 +00:00
Merge branch 'codex/production-intelligence-terminal' into codex/issue-3-acled-diagnostics-auth-tests
All checks were successful
Codex Template Compliance / template-compliance (pull_request) Successful in 5s
Details
Build / test-and-image (pull_request) Successful in 48s
Details
833b7dedd7
MrSphay merged commit 7a562bc8cf into codex/production-intelligence-terminal 2026-05-17 15:48:06 +00:00
MrSphay deleted branch codex/issue-3-acled-diagnostics-auth-tests 2026-05-17 15:48:07 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
design-revert
Reverts visual/design changes
 enhancement
New feature or product improvement
 frontend-redesign
Frontend redesign and app-shell/UI work
 marketing-finalization
Product presentation, README, packaging metadata, and customer-facing communication.
 product
User-facing product capability or workflow
 research
Research-originated product idea ready for implementation design
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
MrSphay
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MrSphay/intelligence-terminal#14
Delete Branch "codex/issue-3-acled-diagnostics-auth-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?