MrSphay/intelligence-terminal
1
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: avoid double-counting fetch failures #33

Merged
MrSphay merged 2 commits from codex/issue-15-fetch-metrics into codex/production-intelligence-terminal 2026-05-17 15:59:29 +00:00
Conversation 0 Commits 2 Files Changed 2 +87 -11
MrSphay commented 2026-05-17 12:40:15 +00:00
Owner
Copy Link

Addresses #15.\n\nChanges:\n- Records exactly one fetch metric per network attempt in safeFetch and safeFetchText.\n- Preserves HTTP failure status, body byte count, duration, and error text without a second catch metric.\n- Records HTML/non-JSON 200 responses as failed JSON-shape errors instead of successful fetches.\n- Adds regression coverage for HTTP failure, HTML response, and retry attempt accounting.\n\nValidation:\n- git diff --check (only Windows CRLF warnings).\n- Runner-only constraint honored; no local npm/node tests executed.

Addresses #15.\n\nChanges:\n- Records exactly one fetch metric per network attempt in safeFetch and safeFetchText.\n- Preserves HTTP failure status, body byte count, duration, and error text without a second catch metric.\n- Records HTML/non-JSON 200 responses as failed JSON-shape errors instead of successful fetches.\n- Adds regression coverage for HTTP failure, HTML response, and retry attempt accounting.\n\nValidation:\n- git diff --check (only Windows CRLF warnings).\n- Runner-only constraint honored; no local npm/node tests executed.
MrSphay added 1 commit 2026-05-17 12:40:16 +00:00
fix: avoid double-counting fetch failures
All checks were successful
Codex Template Compliance / template-compliance (pull_request) Successful in 6s
Details
Build / test-and-image (pull_request) Successful in 49s
Details
08d24594c1
MrSphay added 1 commit 2026-05-17 15:56:16 +00:00
Merge branch 'codex/production-intelligence-terminal' into codex/issue-15-fetch-metrics
All checks were successful
Codex Template Compliance / template-compliance (pull_request) Successful in 5s
Details
Build / test-and-image (pull_request) Successful in 55s
Details
18b2e61678
MrSphay merged commit e0345e2de3 into codex/production-intelligence-terminal 2026-05-17 15:59:29 +00:00
MrSphay deleted branch codex/issue-15-fetch-metrics 2026-05-17 15:59:30 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
design-revert
Reverts visual/design changes
 enhancement
New feature or product improvement
 frontend-redesign
Frontend redesign and app-shell/UI work
 marketing-finalization
Product presentation, README, packaging metadata, and customer-facing communication.
 product
User-facing product capability or workflow
 research
Research-originated product idea ready for implementation design
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
MrSphay
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MrSphay/intelligence-terminal#33
Delete Branch "codex/issue-15-fetch-metrics"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?