Fix Cookbook container-local model endpoints (#1223)

Co-authored-by: ghreprimand <203024559+ghreprimand@users.noreply.github.com>

tests/test_cookbook_endpoint_registration.py

@@ -0,0 +1,30 @@
+from pathlib import Path
+
+
+ROOT = Path(__file__).resolve().parents[1]
+COOKBOOK_RUNNING = ROOT / "static" / "js" / "cookbookRunning.js"
+
+
+def _source() -> str:
+    return COOKBOOK_RUNNING.read_text(encoding="utf-8")
+
+
+def test_cookbook_marks_local_endpoint_registration_as_container_local():
+    src = _source()
+    assert "function _appendCookbookEndpointScope" in src
+    assert "fd.append('container_local', 'true')" in src
+    assert src.count("_appendCookbookEndpointScope(fd,") >= 3
+
+
+def test_cookbook_does_not_use_local_as_endpoint_hostname():
+    src = _source()
+    assert "function _connectHostFromRemote" in src
+    assert "if (!host || host === 'local') return fallback;" in src
+    assert "const rawHost = task.remoteHost || 'localhost';" not in src
+
+
+def test_cookbook_advertised_bind_urls_keep_connectable_host():
+    src = _source()
+    assert "function _endpointFromAdvertisedUrl" in src
+    assert "_isAnyBindHost(u.hostname) ? currentHost" in src
+    assert "host = u.hostname || host;" not in src

tests/test_endpoint_probing.py

@@ -49,6 +49,7 @@ from routes.model_routes import (
     _ping_endpoint,
     _probe_single_model,
     _classify_endpoint,
+    _rewrite_loopback_for_docker,
     _PROVIDER_CURATED,
 )
 
@@ -192,6 +193,38 @@ class TestPingEndpoint:
         }
 
 
+# ── Docker loopback rewrite ──
+
+class TestDockerLoopbackRewrite:
+    def test_manual_loopback_rewrites_to_docker_host_when_available(self, monkeypatch):
+        monkeypatch.setattr(model_routes, "_docker_host_gateway_reachable", lambda: True)
+        assert (
+            _rewrite_loopback_for_docker("http://localhost:8000/v1")
+            == "http://host.docker.internal:8000/v1"
+        )
+
+    def test_cookbook_container_local_loopback_stays_inside_container(self, monkeypatch):
+        monkeypatch.setattr(model_routes, "_docker_host_gateway_reachable", lambda: True)
+        assert (
+            _rewrite_loopback_for_docker("http://localhost:8000/v1", container_local=True)
+            == "http://localhost:8000/v1"
+        )
+
+    def test_bind_address_becomes_connectable_loopback_for_container_local(self, monkeypatch):
+        monkeypatch.setattr(model_routes, "_docker_host_gateway_reachable", lambda: True)
+        assert (
+            _rewrite_loopback_for_docker("http://0.0.0.0:8000/v1", container_local=True)
+            == "http://127.0.0.1:8000/v1"
+        )
+
+    def test_bind_address_becomes_connectable_loopback_on_native_install(self, monkeypatch):
+        monkeypatch.setattr(model_routes, "_docker_host_gateway_reachable", lambda: False)
+        assert (
+            _rewrite_loopback_for_docker("http://0.0.0.0:8000/v1")
+            == "http://127.0.0.1:8000/v1"
+        )
+
+
 # ── _probe_single_model: completion probe ──
 
 class TestProbeSingleModel: