MrSphay/odysseus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(models): make pinned models visible in chat UI (#2481)

Browse Source 
Two bugs prevented pinned models from appearing in the chat model picker:

1. _fetch_models() only used _cached_model_ids(), ignoring pinned_models.
   Since Fireworks AI doesn't list kimi-k2p6-turbo in /v1/models, the
   cached list was empty, so the endpoint showed as offline with no models.

2. _curate_models() filtered unknown pinned IDs into models_extra, but the
   chat UI only reads models (primary list). Pinned models stayed invisible.

Fix: use _visible_models() to merge cached + pinned, then promote pinned
IDs from models_extra to models so they appear in the dropdown.

Closes #1521 follow-up
This commit is contained in:
WasserEsser
2026-06-04 19:17:37 +02:00
committed by GitHub
parent 34c9a8adb1
commit 20cc23c9bd
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
routes/model_routes.py
View File

@@ -1029,12 +1029,13 @@ def setup_model_routes(model_discovery):
for ep in endpoints: for ep in endpoints:
base = _normalize_base(ep.base_url) base = _normalize_base(ep.base_url)
provider = _detect_provider(base) provider = _detect_provider(base)
# Use cached models — background refresh keeps them updated # Merge cached + pinned models, then filter out hidden ones
model_ids = _cached_model_ids(ep)
ep_model_type = getattr(ep, "model_type", None) or "llm" ep_model_type = getattr(ep, "model_type", None) or "llm"
# Filter out hidden (probe-failed) models model_ids = _visible_models(
hidden = _hidden_model_ids(ep) _cached_model_ids(ep),
model_ids = [m for m in model_ids if m not in hidden] ep.hidden_models,
getattr(ep, "pinned_models", None),
)
# Build correct URL based on provider # Build correct URL based on provider
chat_url = build_chat_url(base) chat_url = build_chat_url(base)
kind = _effective_endpoint_kind(ep, base) kind = _effective_endpoint_kind(ep, base)
@@ -1043,6 +1044,13 @@ def setup_model_routes(model_discovery):
if model_ids: if model_ids:
curated_key = _match_provider_curated(base, None) curated_key = _match_provider_curated(base, None)
curated, extra = _curate_models(model_ids, curated_key) curated, extra = _curate_models(model_ids, curated_key)
# Pinned models are admin-selected — they always belong in the
# primary curated list, not buried in extras.
pinned = _normalize_model_ids(getattr(ep, "pinned_models", None))
for m in pinned:
if m not in curated:
curated.append(m)
extra = [m for m in extra if m not in pinned]
items.append({ items.append({
"host": "custom", "host": "custom",
"port": 0, "port": 0,