From 3b9c60149821c015d327d2ee54ae8c159a10c8a7 Mon Sep 17 00:00:00 2001 From: red person Date: Wed, 3 Jun 2026 08:06:42 +0300 Subject: [PATCH] Skip invalid personal CLI index rows (#1571) --- scripts/odysseus-personal | 6 +++++- tests/test_personal_cli_rows.py | 31 +++++++++++++++++++++++++++++++ 2 files changed, 36 insertions(+), 1 deletion(-) create mode 100644 tests/test_personal_cli_rows.py diff --git a/scripts/odysseus-personal b/scripts/odysseus-personal index 3f49374..2fcdbbf 100755 --- a/scripts/odysseus-personal +++ b/scripts/odysseus-personal @@ -42,8 +42,12 @@ def _manager() -> PersonalDocsManager: return _mgr +def _file_rows(files): + return [f for f in files or [] if isinstance(f, dict)] + + def cmd_list(args): - files = getattr(_manager(), "index", []) or [] + files = _file_rows(getattr(_manager(), "index", []) or []) out = [ {"name": f.get("name"), "size": f.get("size"), "path": f.get("path", "")} for f in files diff --git a/tests/test_personal_cli_rows.py b/tests/test_personal_cli_rows.py new file mode 100644 index 0000000..b9fa861 --- /dev/null +++ b/tests/test_personal_cli_rows.py @@ -0,0 +1,31 @@ +import importlib.machinery +import importlib.util +import sys +import types +from pathlib import Path +from unittest.mock import MagicMock + + +ROOT = Path(__file__).resolve().parents[1] + + +def _load_cli(monkeypatch): + personal_docs = types.ModuleType("src.personal_docs") + personal_docs.PersonalDocsManager = MagicMock() + monkeypatch.setitem(sys.modules, "src.personal_docs", personal_docs) + path = ROOT / "scripts" / "odysseus-personal" + loader = importlib.machinery.SourceFileLoader("odysseus_personal_cli", str(path)) + spec = importlib.util.spec_from_loader(loader.name, loader) + module = importlib.util.module_from_spec(spec) + loader.exec_module(module) + return module + + +def test_file_rows_skips_invalid_rows(monkeypatch): + cli = _load_cli(monkeypatch) + + assert cli._file_rows([ + {"name": "notes.txt", "path": "/tmp/notes.txt"}, + "bad-row", + None, + ]) == [{"name": "notes.txt", "path": "/tmp/notes.txt"}]