fix: search query helpers crash on a non-string query (#1604)

tests/test_search_query_nonstring.py

@@ -0,0 +1,40 @@
+"""Regression: search query helpers must tolerate a non-string query.
+
+These helpers did `query.strip()`, `query.lower()`, `re.split(..., query)`,
+`re.search(..., query)` directly, so a None / non-string query (e.g. from a
+caller that didn't coerce) raised TypeError/AttributeError. They now return a
+safe default for non-strings.
+"""
+import importlib.machinery
+import importlib.util
+from pathlib import Path
+
+_PATH = Path(__file__).resolve().parents[1] / "services" / "search" / "query.py"
+
+
+def _load():
+    # Load the module file directly so the package __init__ (which imports
+    # httpx) isn't required.
+    loader = importlib.machinery.SourceFileLoader("odysseus_search_query", str(_PATH))
+    spec = importlib.util.spec_from_loader(loader.name, loader)
+    module = importlib.util.module_from_spec(spec)
+    loader.exec_module(module)
+    return module
+
+
+def test_helpers_handle_none():
+    q = _load()
+    assert q._detect_question_type(None) is None
+    assert q._split_multi_part(None) == []
+    assert q._extract_site_filter(None) == ("", None)
+    assert q._is_news_query(None) is False
+    # entry points coerce and do not raise
+    assert isinstance(q.enhance_query(None)[0], str)
+    assert isinstance(q.build_enhanced_query(123), str)
+
+
+def test_valid_query_still_works():
+    q = _load()
+    assert q._detect_question_type("who is bob") == "who"
+    assert q._is_news_query("latest news today") is True
+    assert q._extract_site_filter("cats site:x.com")[1] == "x.com"