MrSphay/odysseus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: use safe .get for id lookup in uploads.json to prevent KeyError (#1465)

Browse Source 
When uploads.json contains a malformed entry without an 'id' key,
the file-serve and lookup helpers crash with KeyError instead of
gracefully skipping the entry.
This commit is contained in:
Paulo Victor Cordeiro
2026-06-03 06:12:00 +01:00
committed by GitHub
parent dfbc94f929
commit 844dbf6a22
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
routes/upload_routes.py
View File

@@ -111,7 +111,7 @@ def setup_upload_routes(upload_handler):
if os.path.exists(uploads_db): if os.path.exists(uploads_db):
with open(uploads_db, encoding="utf-8") as f: with open(uploads_db, encoding="utf-8") as f:
db = json.load(f) db = json.load(f)
info = next((fi for fi in db.values() if fi["id"] == file_id), None) info = next((fi for fi in db.values() if fi.get("id") == file_id), None)
if info: if info:
original_name = info.get("name", file_id) original_name = info.get("name", file_id)
auth_mgr = getattr(request.app.state, "auth_manager", None) auth_mgr = getattr(request.app.state, "auth_manager", None)
@@ -159,7 +159,7 @@ def setup_upload_routes(upload_handler):
if os.path.exists(uploads_db): if os.path.exists(uploads_db):
with open(uploads_db, encoding="utf-8") as f: with open(uploads_db, encoding="utf-8") as f:
db = json.load(f) db = json.load(f)
info = next((fi for fi in db.values() if fi["id"] == file_id), None) info = next((fi for fi in db.values() if fi.get("id") == file_id), None)
return info return info
def _vision_cache_path(file_id: str) -> str: def _vision_cache_path(file_id: str) -> str: