MrSphay/odysseus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: is_youtube_url (services) crashes on a non-string url (#1753)

Browse Source
This commit is contained in:
Afonso Coutinho
2026-06-03 05:24:24 +01:00
committed by GitHub
parent 33bf975597
commit d2f6e8068d
2 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
services/youtube/youtube_handler.py
View File

@@ -59,6 +59,8 @@ def init_youtube():
def is_youtube_url(url: str) -> bool: def is_youtube_url(url: str) -> bool:
if not isinstance(url, str):
return False
return "youtube.com" in url or "youtu.be" in url return "youtube.com" in url or "youtu.be" in url

13
tests/test_is_youtube_url_nonstring_svc.py Normal file
View File

@@ -0,0 +1,13 @@
from services.youtube.youtube_handler import is_youtube_url
def test_is_youtube_url_handles_non_string():
# `"youtube.com" in url` raises TypeError on a non-string url.
assert is_youtube_url(123) is False
assert is_youtube_url(None) is False
assert is_youtube_url(["https://youtu.be/x"]) is False
def test_is_youtube_url_detects_real_urls():
assert is_youtube_url("https://www.youtube.com/watch?v=x") is True
assert is_youtube_url("https://youtu.be/x") is True