Ignore non-string background stream deltas (#1549)
This commit is contained in:
@@ -53,7 +53,9 @@ async def _drain_agent(sess, messages):
|
|||||||
if not isinstance(d, dict):
|
if not isinstance(d, dict):
|
||||||
continue
|
continue
|
||||||
if "delta" in d:
|
if "delta" in d:
|
||||||
full += d["delta"]
|
delta = d.get("delta")
|
||||||
|
if isinstance(delta, str):
|
||||||
|
full += delta
|
||||||
elif d.get("type") == "agent_step":
|
elif d.get("type") == "agent_step":
|
||||||
round_num = d.get("round", round_num)
|
round_num = d.get("round", round_num)
|
||||||
elif d.get("type") == "tool_output":
|
elif d.get("type") == "tool_output":
|
||||||
|
|||||||
39
tests/test_bg_monitor_stream.py
Normal file
39
tests/test_bg_monitor_stream.py
Normal file
@@ -0,0 +1,39 @@
|
|||||||
|
import asyncio
|
||||||
|
import sys
|
||||||
|
import types
|
||||||
|
from types import SimpleNamespace
|
||||||
|
|
||||||
|
from src import bg_monitor
|
||||||
|
|
||||||
|
|
||||||
|
def test_drain_agent_ignores_non_string_deltas(monkeypatch):
|
||||||
|
async def fake_stream_agent_loop(*args, **kwargs):
|
||||||
|
yield 'data: {"delta": null}'
|
||||||
|
yield 'data: {"delta": ["bad"]}'
|
||||||
|
yield 'data: {"delta": "ok"}'
|
||||||
|
yield 'data: {"type": "agent_step", "round": 2}'
|
||||||
|
yield 'data: {"type": "tool_output", "tool": "shell", "output": "done"}'
|
||||||
|
yield "data: [DONE]"
|
||||||
|
|
||||||
|
agent_loop = types.ModuleType("src.agent_loop")
|
||||||
|
agent_loop.stream_agent_loop = fake_stream_agent_loop
|
||||||
|
monkeypatch.setitem(sys.modules, "src.agent_loop", agent_loop)
|
||||||
|
|
||||||
|
sess = SimpleNamespace(
|
||||||
|
endpoint_url="http://example.test",
|
||||||
|
model="model",
|
||||||
|
headers=None,
|
||||||
|
context_length=0,
|
||||||
|
id="s1",
|
||||||
|
)
|
||||||
|
|
||||||
|
full, events = asyncio.run(bg_monitor._drain_agent(sess, []))
|
||||||
|
|
||||||
|
assert full == "ok"
|
||||||
|
assert events == [{
|
||||||
|
"round": 2,
|
||||||
|
"tool": "shell",
|
||||||
|
"command": None,
|
||||||
|
"output": "done",
|
||||||
|
"exit_code": None,
|
||||||
|
}]
|
||||||
Reference in New Issue
Block a user