8c376d2b0e
The agent soft-trims input context to `agent_input_token_budget` (default 6000). The old computation `min(context_length or budget, budget)` made the 6000 default a hard ceiling for every model, so 128K/1M context models were silently capped at 6000 input tokens — now that num_ctx is sent correctly (#1056), this was the last barrier to actually using a long context window. This derives the default budget from the model's discovered context window (~85%, capped at a generous hard max) while honouring an explicit user setting exactly (clamped to the window). When the window is unknown it falls back to the previous value, so behaviour is unchanged for that case. - src/context_budget.py: pure `compute_input_token_budget()` (unit-testable) - src/settings.py: `is_setting_overridden()` to tell an explicit user value from the merged default (load_settings merges DEFAULT_SETTINGS, so equality alone can't distinguish them) - src/agent_loop.py: use the helper in the soft-trim path Covered by tests/test_context_budget.py (6 cases). Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
47 lines
1.8 KiB
Python
47 lines
1.8 KiB
Python
"""Issue #1170 — the agent input-token budget adapts to the model context window.
|
|
|
|
Pins the pure budget computation and the explicit-override detection.
|
|
"""
|
|
|
|
import json
|
|
|
|
from src.context_budget import compute_input_token_budget, DEFAULT_HARD_MAX
|
|
|
|
|
|
def test_default_scales_to_context_window():
|
|
# Not explicit, big window -> ~85% of the window (the old code capped at 6000).
|
|
assert compute_input_token_budget(6000, 128000, explicit=False) == int(128000 * 0.85)
|
|
|
|
|
|
def test_default_capped_at_hard_max_for_huge_windows():
|
|
assert compute_input_token_budget(6000, 1_000_000, explicit=False) == DEFAULT_HARD_MAX
|
|
|
|
|
|
def test_explicit_budget_is_honoured():
|
|
# User explicitly chose 6000 -> keep it even on a 128K model.
|
|
assert compute_input_token_budget(6000, 128000, explicit=True) == 6000
|
|
# A larger explicit budget is honoured too, clamped to the window.
|
|
assert compute_input_token_budget(50000, 128000, explicit=True) == 50000
|
|
|
|
|
|
def test_explicit_budget_clamped_to_window():
|
|
assert compute_input_token_budget(200000, 32000, explicit=True) == 32000
|
|
|
|
|
|
def test_unknown_window_falls_back_to_configured():
|
|
assert compute_input_token_budget(6000, 0, explicit=False) == 6000
|
|
assert compute_input_token_budget(0, 0, explicit=False) == 6000 # default
|
|
|
|
|
|
def test_is_setting_overridden_reads_raw_saved_file(tmp_path, monkeypatch):
|
|
import src.settings as settings
|
|
|
|
f = tmp_path / "settings.json"
|
|
f.write_text(json.dumps({"agent_input_token_budget": 12000}), encoding="utf-8")
|
|
monkeypatch.setattr(settings, "SETTINGS_FILE", str(f))
|
|
assert settings.is_setting_overridden("agent_input_token_budget") is True
|
|
assert settings.is_setting_overridden("some_unset_key") is False
|
|
|
|
f.write_text(json.dumps({}), encoding="utf-8")
|
|
assert settings.is_setting_overridden("agent_input_token_budget") is False
|