Add a hashchange handler for #document-<id> so refresh / URL-bar nav opens the document, and replace the silent console.error in loadDocument with a user-facing toast. Closes #560
34 lines
1.3 KiB
Python
34 lines
1.3 KiB
Python
"""Regression guards for in-chat document deep-links (#document-<id>).
|
|
|
|
The frontend module is browser-coupled (window/fetch/document) so there's
|
|
no JS unit harness for it — these pin the source-level invariants that the
|
|
404-silent-failure fix depends on. See issue #560.
|
|
"""
|
|
|
|
from pathlib import Path
|
|
|
|
_REPO = Path(__file__).resolve().parents[1]
|
|
|
|
|
|
def test_chat_document_links_use_the_document_id():
|
|
"""The list/open tool must anchor to the real document id, not a slug —
|
|
a slug 404s against the UUID-keyed /api/document/<id> route."""
|
|
src = (_REPO / "src" / "tool_implementations.py").read_text(encoding="utf-8")
|
|
assert "(#document-{d.id})" in src
|
|
assert "(#document-{doc.id})" in src
|
|
|
|
|
|
def test_document_deeplink_handled_on_hashchange_and_load():
|
|
"""#document-<id> in the URL must open the doc on refresh / URL-bar nav,
|
|
not just on click."""
|
|
js = (_REPO / "static" / "js" / "document.js").read_text(encoding="utf-8")
|
|
assert "addEventListener('hashchange', _maybeOpenDocFromHash)" in js
|
|
assert "#document-" in js
|
|
|
|
|
|
def test_failed_document_load_surfaces_user_error():
|
|
"""A missing/failed document must tell the user, not fail silently."""
|
|
js = (_REPO / "static" / "js" / "document.js").read_text(encoding="utf-8")
|
|
assert "uiModule.showError" in js
|
|
assert "Document not found" in js
|