# Porting Notes

## Source and Target

- Original mod: Create: Limited Draining
- Original repository: https://github.com/JasdewStarfield/CreateLimitedDraining
- Original branch used as source basis: 1.20.1
- Target: Minecraft 1.21.1, NeoForge 21.1.228, Create 6.0.10

## Main Changes

- Replaced ForgeGradle setup with NeoForge ModDevGradle.
- Updated Java toolchain from 17 to 21.
- Replaced Forge config/event imports with NeoForge equivalents.
- Updated `mods.toml` metadata to generated `neoforge.mods.toml`.
- Updated NBT mixin method signatures for Create/Minecraft 1.21.1 `HolderLookup.Provider` parameters.
- Kept behavior minimal: rule-based restriction of Create Hose Pulley infinite draining.

## Verification

- `gradlew build`: successful.
- `gradlew runClient`: successful startup; Create 6.0.10 and `createlimiteddraining` loaded.
- `gradlew runServer`: dedicated server loaded Create and the port, generated a world, and reached `Done`; Java server processes were stopped after the smoke-test timeout.

## Expected Risk Areas

- Manual gameplay verification of Hose Pulley infinite-draining behavior is still pending.
- Create internal method signatures are compile-verified, but the mixin behavior should be exercised in a test world.
- The exact Create Maven artifact resolved as `create-1.21.1-6.0.10-280-slim.jar` and reports mod version `6.0.10` at runtime.

## Next Steps

- Create a test world and verify lava infinite draining is allowed in Nether biomes and denied outside configured biome rules.
- Inspect the generated common config after changing `drainingRules` values.
- Consider adding a lightweight GameTest or scripted manual QA notes for Hose Pulley behavior.