MrSphay/Modrinth-plus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: various fixes for versions (#5238)

Browse Source 
* fix: environment not showing when has mod loaders

* fix: weird snapshot format by only grouping consecutive tags with 3 or more

* fix: 26.1 snapshots not grouped properly in mc version picker

* remove debug console.log
This commit is contained in:
Truman Gao
2026-01-28 14:46:07 -07:00
committed by GitHub
parent deaa57fa15
commit 9c309e6da2
3 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/frontend/src/components/ui/create-project-version/components/McVersionPicker.vue
View File

@@ -155,7 +155,7 @@ function groupVersions(gameVersions: GameVersion[]) {
const groups: Record<string, string[]> = {} const groups: Record<string, string[]> = {}
let currentGroupKey = getSnapshotGroupKey(gameVersions.find((v) => v.major)?.version || '') let currentGroupKey
gameVersions.forEach((gameVersion) => { gameVersions.forEach((gameVersion) => {
if (gameVersion.version_type === 'release') { if (gameVersion.version_type === 'release') {

9
apps/frontend/src/providers/version/manage-version-modal.ts
View File

@@ -426,9 +426,12 @@ export function createManageVersionContext(
} }
// Stage visibility computeds (inlined) // Stage visibility computeds (inlined)
const noEnvironmentProject = computed( const noEnvironmentProject = computed(() => {
() => projectType.value !== 'mod' && projectType.value !== 'modpack', const hasModLoaders = draftVersion.value.loaders.some((loader) =>
) PROJECT_TYPE_LOADERS.mod.includes(loader),
)
return !hasModLoaders && projectType.value !== 'modpack'
})
const noDependenciesProject = computed(() => projectType.value === 'modpack') const noDependenciesProject = computed(() => projectType.value === 'modpack')
const getProject = async (projectId: string) => { const getProject = async (projectId: string) => {

11
packages/utils/projects.ts
View File

@@ -126,12 +126,13 @@ export function formatVersionsForDisplay(
// show all snapshots if there's no release versions // show all snapshots if there's no release versions
if (releaseVersionsAsRanges.length === 0) { if (releaseVersionsAsRanges.length === 0) {
const snapshotVersionsAsRanges = groupConsecutiveIndices( const snapshotVersions = inputVersions.filter((projVer) =>
inputVersions.filter((projVer) => allSnapshots.some((gameVer) => gameVer.version === projVer),
allSnapshots.some((gameVer) => gameVer.version === projVer),
),
allSnapshots,
) )
const snapshotVersionsAsRanges =
snapshotVersions.length > 3
? groupConsecutiveIndices(snapshotVersions, allSnapshots)
: snapshotVersions
output = [...snapshotVersionsAsRanges, ...output] output = [...snapshotVersionsAsRanges, ...output]
} else { } else {
output = [...releaseVersionsAsRanges, ...output] output = [...releaseVersionsAsRanges, ...output]